Properly sort marker resolution by relevance #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the marker resolution is sorted, but markers with the *lowest* relevance are show on top, and therefore these are selected by default. This is confusing and gives a bad user experience, also this is the reverse order than we use when offering the quickfix in the editor itself. This now sorts the list that the marker with the highest relevance is on top and selected by default.
|
OK, regression from f13fb49 |
|
The "new style" was hardly readable, understandable and debugable and introduced bugs ... So yes I always prefer "more lines" if it makes the code more clear because code is written once and read often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the marker resolution is sorted, but markers with the lowest relevance are show on top, and therefore these are selected by default. This is confusing and gives a bad user experience, also this is the reverse order than we use when offering the quickfix in the editor itself.
This now sorts the list that the marker with the highest relevance is on top and selected by default.