Closing all Shells and the Display when browsertab is closed #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing all Shells results in dispose events, and allows for cleaning stuff up. Also-by: Ralf Schlesinger <[email protected]>
uiThread.switchThread() is needed, was removed in previous version Also-by: Ralf Schlesinger <[email protected]>
|
Can one of the admins verify this patch? |
|
ok to test |
|
I don't see how the Browser changes here are related to the Shell closing. Is this by mistake? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing all Shells results in dispose events, and allows for cleaning
stuff up.
Also-by: Ralf Schlesinger [email protected]