Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds tests for error cases (return 400) to fms-server #35

Closed
wants to merge 1 commit into from
Closed

adds tests for error cases (return 400) to fms-server #35

wants to merge 1 commit into from

Conversation

eriksven
Copy link
Contributor

No description provided.

@eriksven eriksven requested a review from sophokles73 January 15, 2024 09:00
@eriksven eriksven force-pushed the feature/test-errors-fms-server branch from 026de4b to 25df8f5 Compare January 16, 2024 08:53
sophokles73
sophokles73 requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add line breaks at the end of the files?

sophokles73
sophokles73 reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests you are doing seem to be dealing with request parameter parsing only. Isn't it possible to use simple unit tests for this instead of running full blown integration tests?

@eriksven
Copy link
Contributor Author

Sure, I added the unit tests in #40 and am therefore closing #37.

@eriksven eriksven closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophokles73 sophokles73 sophokles73 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eriksven @sophokles73