Rename publish npm script to avoid rerun of publish #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed publish script to publish:latest. Before the script was executed everytime we ran npm publish. This then fails because you cannot publish the same version twice. Also prevents the latest tag to be applied on next publish. Also it probably would have ended in a loop. Contributed on behalf of STMicroelectronics
jfaltermeier
approved these changes
Dec 8, 2023
Fix if-statements. Update texts. Update docker build commands to take the location into account. Use next instead of 0.9.0-next for monitor-theia extension. Contributed on behalf of STMicroelectronics
|
@jfaltermeier Could you take another look, i also fixed the demo publishing. The changes are minor and i linked the successful runs where the demos were published. |
jfaltermeier
approved these changes
Dec 8, 2023
|
Thanks, lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to fix failing builds: https://github.com/eclipsesource/theia-cloud/actions/runs/7140492012. Artifacts have been published correctly though. So no rerun is necessary. I just noticed that it will rerun, as the common package has been changed.
Renamed publish script to publish:latest.
Before the script was executed everytime we ran npm publish.
This then fails because you cannot publish the same version twice.
Also prevents the latest tag to be applied on next publish. Also it probably would have ended in a loop.
Demo CI fixes:
Fix if-statements.
Update texts.
Update docker build commands to take the location into account.
Use next instead of 0.9.0-next for monitor-theia extension.
Successful runs:
Contributed on behalf of STMicroelectronics