Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 20 #269

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Update to node 20 #269

merged 2 commits into from
Jan 12, 2024

Conversation

sgraband
Copy link
Contributor

Enforce node 20 in the node directory.
Adapt workflows to use node 20.
Adapt dockerfiles to use node 20.
Fix eslint integration for landing-page.
Clean up dependencies in node package.
Moved all reused devDependencies to root of node directory.
Adapt version update script for publish:next scripts.
Regenerated package-lock.json.

Enforce node 20 in the node directory.
Adapt workflows to use node 20.
Adapt dockerfiles to use node 20.
Fix eslint integration for landing-page.
Clean up dependencies in node package.
Moved all reused devDependencies to root of node directory.
Adapt version update script for publish:next scripts.
Regenerated package-lock.json.
@sgraband sgraband requested a review from jfaltermeier January 11, 2024 11:48
@sgraband
Copy link
Contributor Author

The first attempt to build failed but the second one was successfull: https://github.com/eclipsesource/theia-cloud/actions/runs/7488309043/attempts/1.

Not sure if this is really a problem. We should probably observe if this happens more often.

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think there are two package locks that need updating still:

  • theia-cloud/demo/dockerfiles/demo-theia-docker/project/web/package-lock.json
  • theia-cloud/demo/dockerfiles/demo-theia-monitor-vscode/project/web/package-lock.json

@sgraband sgraband requested a review from jfaltermeier January 12, 2024 15:01
@sgraband sgraband merged commit 27e56f9 into main Jan 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants