Unify the existing landing and try now pages #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgraband
approved these changes
May 23, 2024
- Remove vue based simple landing page - Migrate Try Now page from CRA to ViteJS and add as new `landing-page` - Increase Keycloak dependency from 20.0.3 to 20.0.5 - The new landing-page uses its own tsconfig.json based on the one generated by Vite - Adapt landing page dockerfile to new vite-based page - Remove terms and conditions - misc: Update node VSCode settings Contributed on behalf of STMicroelectronics
Adapt the base tsconfig to build as module ES2020 instead of commonjs. The ViteJS landing page does not work properly with the common package built as commonjs. Furthermore, browser and node now natively support ES modules. Contributed on behalf of STMictroelectronics
- Reset default tsconfig module setting to commonjs - Publish common module as commonjs and esm - Leave legacy `main` and `types` entries in package json pointing to commonjs. Node resolution mode `node` does not seem to recognize the new `exports` syntax - Add `exports` entries for esm and cjs to package.json - Adapt landing page Dockerfile to changes Contributed on behalf of STMicroelectronics
- Extend common config with properties for info text/title, loading message, and logo file extenion - Adapt landing page to use config if available. Otherwise, fall back to default texts - Show info text before and after login. Hide it when an error is shown. Contributed on behalf STMicroelectronics
- Remove source code - Remove Dockerfile and CI - Regenerate package-lock.json to remove try now workspace - Adapt terraform values to use the landing page image Contributed on behalf of STMicroelectronics
lucas-koehler
force-pushed
the
lk/unify-landing-pages
branch
from
f890135 to
7136198
Compare
|
I rebased the changes to fix the merge conflicts that arose from the Theia.Cloud -> Theia Cloud renamings of the operator library PR. This as straightforward as the conflicts only came from changes in files that are now deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See eclipse-theia/theia-cloud-helm#58 for the Helm chart changes for extended configuration options.
Contributed on behalf of STMicroelectronics