Move default behavior into library #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make code reuseable and reduce complexity of minimal example (defaultoperator). Make leader election optional by making it not the default implementation, but a optional class.
There was a problem hiding this comment.
Hi @sgraband , thanks for the refactoring! It already looks pretty good to me. I have two remarks inline. Please have a look :)
...loud.operator/src/main/java/org/eclipse/theia/cloud/operator/AbstractTheiaCloudOperator.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/theia/cloud/operator/LeaderElectionTheiaCloudOperatorLauncher.java
Outdated
Show resolved
Hide resolved
Also remove the abstract so it can directly be used. Use it directly in the DefaultTheiaCloudOperatorModule. Remove the DefaultTheiaCloudOperator as it is no longer needed. Extract LeaderElection in separate method for easier customization. Also make the other methods in the leader election protected.
|
@lucas-koehler Thanks for the feedback. I incorporated both of your suggestions. Let me know what you think. |
lucas-koehler
approved these changes
Jul 16, 2024
|
@jfaltermeier Do you want to take a look as well? |
jfaltermeier
approved these changes
Jul 16, 2024
...src/main/java/org/eclipse/theia/cloud/defaultoperator/DefaultTheiaCloudOperatorLauncher.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make code reuseable and reduce complexity of minimal example (defaultoperator).
Make leader election optional by making it not the default implementation, but a optional class.
Note: This is just a proposal, please feel free to comment if you would like to structure this differently or have any other objections.