-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Kubernetes resource naming and set up common unit tests #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgraband
reviewed
Jul 19, 2024
...eclipse.theia.cloud.common/src/main/java/org/eclipse/theia/cloud/common/util/NamingUtil.java
Outdated
Show resolved
Hide resolved
...eclipse.theia.cloud.common/src/main/java/org/eclipse/theia/cloud/common/util/NamingUtil.java
Outdated
Show resolved
Hide resolved
Rework the naming of Kubernetes resources for workspaces and sessions in the common package used by operator and service. The goal is to make resource names more readable and contain useful information. Resource names now contain a prefix, optional identifier, user, app definition and the last segment of the source CRs (session, workspace, app definition) UID. Also configure unit tests using JUnit 5 for the common maven module and add some tests for the new name generation.
The setting from the java-formatter.xml does not seem to be respected. Set the tab width explicitly via `editor.tabSize` to ensure this works independently of the VSCode settings regarding tab size.
lucas-koehler
force-pushed
the
lk/k8s-resource-names
branch
from
July 19, 2024 13:52
6d5ab59
to
d7a8a0c
Compare
sgraband
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324
Note: This will need a rebase if the formatting PR #325 is merged first. Otherwise, the touched Java files need to be formatted in the PR, too.
Rework the naming of Kubernetes resources for workspaces and sessions in the common package used by operator and service.
The goal is to make resource names more readable and contain useful information. Resource names now contain a prefix, optional identifier, user, app definition and the last segment of the source CRs (session, workspace, app definition) UID.
Also configure unit tests using JUnit 5 for the common maven module and add some tests for the new name generation.
Notes:
email
resp.proxy
to be as short and concise as possible.See an example of created resources for a user
bar
with app definitiontheia-cloud-demo
: