-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #371
Update dependencies #371
Conversation
6e17411
to
1941fbd
Compare
* rollup * vite * body-parser * express * path-to-regexp * send * serve-static * micromatch * webpack * cookie * junit in demos * update workflow actions (use sha for non github actions) * update helm dependencies to latest version * add license information to internal pages Contributed on behalf of STMicroelectronics
1941fbd
to
f7178e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes already look quite good to me :)
I have 2 small remarks inline regarding the license.
I wonder whether we should also update the maven dependencies in https://github.com/eclipse-theia/theia-cloud/blob/main/java/common/maven-conf/pom.xml
I.e. quarkus, maven surefire, etc. Was this missed or left out on purpose?
Note that I did not test this as the changes are pretty small. Let me know if I should.
Co-authored-by: Lucas Koehler <[email protected]>
Co-authored-by: Lucas Koehler <[email protected]>
I checked for a new version of https://mvnrepository.com/artifact/io.javaoperatorsdk/kubernetes-webhooks-framework-core at the beginning of November. I usually pick the corresponding io.fabric8 k8s-client version from this and update Quarkus accordingly, ensuring all dependencies are built with the same or a similar k8s-client version. Since there wasn't a release at this time, I mainly focused on Dependabot alerts for Maven. There’s a new version available now, so I’ll update to it after 1.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update and explanation. LGTM ✨
Contributed on behalf of STMicroelectronics