Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #371

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Update dependencies #371

merged 4 commits into from
Nov 28, 2024

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Nov 4, 2024

  • rollup
  • vite
  • body-parser
  • express
  • path-to-regexp
  • send
  • serve-static
  • micromatch
  • webpack
  • cookie
  • junit in demos
  • update workflow actions (use sha for non github actions)
  • update helm dependencies to latest version (but keycloak)

Contributed on behalf of STMicroelectronics

@jfaltermeier jfaltermeier force-pushed the jf/dependencies branch 3 times, most recently from 6e17411 to 1941fbd Compare November 6, 2024 12:39
@jfaltermeier jfaltermeier changed the title WIP Update dependencies Update dependencies Nov 6, 2024
* rollup
* vite
* body-parser
* express
* path-to-regexp
* send
* serve-static
* micromatch
* webpack
* cookie
* junit in demos

* update workflow actions (use sha for non github actions)

* update helm dependencies to latest version

* add license information to internal pages

Contributed on behalf of STMicroelectronics
@jfaltermeier jfaltermeier marked this pull request as ready for review November 28, 2024 08:49
@jfaltermeier jfaltermeier requested review from sgraband and lucas-koehler and removed request for lucas-koehler November 28, 2024 08:49
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes already look quite good to me :)
I have 2 small remarks inline regarding the license.

I wonder whether we should also update the maven dependencies in https://github.com/eclipse-theia/theia-cloud/blob/main/java/common/maven-conf/pom.xml
I.e. quarkus, maven surefire, etc. Was this missed or left out on purpose?

Note that I did not test this as the changes are pretty small. Let me know if I should.

node/landing-page/package.json Outdated Show resolved Hide resolved
node/testing-page/package.json Outdated Show resolved Hide resolved
@jfaltermeier
Copy link
Contributor Author

The changes already look quite good to me :) I have 2 small remarks inline regarding the license.

I wonder whether we should also update the maven dependencies in https://github.com/eclipse-theia/theia-cloud/blob/main/java/common/maven-conf/pom.xml I.e. quarkus, maven surefire, etc. Was this missed or left out on purpose?

Note that I did not test this as the changes are pretty small. Let me know if I should.

I checked for a new version of https://mvnrepository.com/artifact/io.javaoperatorsdk/kubernetes-webhooks-framework-core at the beginning of November. I usually pick the corresponding io.fabric8 k8s-client version from this and update Quarkus accordingly, ensuring all dependencies are built with the same or a similar k8s-client version.

Since there wasn't a release at this time, I mainly focused on Dependabot alerts for Maven.

There’s a new version available now, so I’ll update to it after 1.0.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and explanation. LGTM ✨

@jfaltermeier jfaltermeier merged commit 5e967ec into main Nov 28, 2024
8 checks passed
@jfaltermeier jfaltermeier deleted the jf/dependencies branch November 28, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants