remove "expected" exception from unit tests

It pollutes the console and makes debugging the build harder.
Asserting can also make the failure mode testing more precise.

Signed-off-by: Matthew Khouzam <[email protected]>

src/test/java/org/eclipse/tracecompass/trace_event_logger/AsyncFileHandlerTest.java

@@ -32,6 +32,7 @@
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.UnsupportedEncodingException;
 import java.util.logging.ErrorManager;
 import java.util.logging.Filter;
 import java.util.logging.Formatter;
@@ -43,7 +44,7 @@
 import org.junit.Test;
 
 /**
- * Test aynchronous file hnandler
+ * Test aynchronous file handler
  */
 public class AsyncFileHandlerTest {
 
@@ -91,19 +92,26 @@ public void testGoodConfigure() {
      * @throws SecurityException
      *             won't happen
      */
-    @Test(expected = IOException.class)
+    @Test
     public void testBadConfigure() throws SecurityException, IOException {
         try (InputStream fis = new FileInputStream(
                 new File("./src/test/java/org/eclipse/tracecompass/trace_event_logger/res/badlogging.properties"))) { //$NON-NLS-1$
+            LogManager manager = LogManager.getLogManager();
             try {
-                LogManager manager = LogManager.getLogManager();
                 manager.readConfiguration(fis);
                 String prop = manager.getProperty("org.eclipse.tracecompass.trace_event_logger.SnapshotHandler.maxEvents"); //$NON-NLS-1$
                 assertNotNull(prop);
             } catch (IOException e) {
                 fail(e.getMessage());
             }
-            new AsyncFileHandler();
+            try {
+                new AsyncFileHandler();
+            } catch (UnsupportedEncodingException e) {
+                assertNotNull(e);
+                assertEquals("uTF-6", e.getMessage()); //$NON-NLS-1$
+                manager.reset();
+                return;
+            }
             fail("should have failed above"); //$NON-NLS-1$
         } catch (FileNotFoundException e) {
             fail(e.getMessage());