Remove references to settings.xml #17
Conversation
.github/workflows/maven-publish.yml
Outdated
| @@ -32,7 +32,7 @@ jobs: | |||
| server-password: MAVEN_PASSWORD | |||
| gpg-passphrase: PASSPHRASE | |||
| - name: Make a snapshot | |||
| run: mvn -Pdeploy -Pproduction --no-transfer-progress --batch-mode clean deploy -U | |||
| run: mvn --no-transfer-progress --batch-mode clean deploy -U | |||
There was a problem hiding this comment.
the profiles should stay (-Pdeploy and -Pproduction)
.github/workflows/maven-publish.yml
Outdated
| server-username: MAVEN_USERNAME | ||
| server-password: MAVEN_PASSWORD | ||
| gpg-passphrase: PASSPHRASE | ||
|
|
||
| - name: Publish to Maven Central Repository | ||
| run: mvn --batch-mode deploy -s $GITHUB_WORKSPACE/settings.xml | ||
| run: mvn --batch-mode deploy |
There was a problem hiding this comment.
shouldn't it also have the profiles here?
| @@ -44,14 +44,13 @@ jobs: | |||
| java-version: '11' | |||
| distribution: 'temurin' | |||
| cache: 'maven' | |||
| server-id: ossrh # Value of the distributionManagement/repository/id field of the pom.xml | |||
There was a problem hiding this comment.
In the GitHub documentation example, the server-id line is kept:
https://docs.github.com/en/actions/publishing-packages/publishing-java-packages-with-maven#publishing-packages-to-the-maven-central-repository-and-github-packages
update: seems the default value is "github", so you want to keep the line:
https://github.com/actions/setup-java#maven-options
There was a problem hiding this comment.
In the doc linked above, they provide some corresponding content of the generated settings.xml - you should "cat" the one(s) generated in your workflow and compare, making sure the parameters you pass tp setup-java are reflected in there.
There was a problem hiding this comment.
ossrh is for maven central AFAIK
github is for github packages
|
An advanced example from the e.g. they use "maven" as value for "server-id": |
There is none Signed-off-by: Matthew Khouzam <[email protected]>
MatthewKhouzam
force-pushed
the
no-settings
branch
from
64df011
to
fdf3ba6
Compare
There is none