[Industry Core KIT] BugFix: remove faulty JSON-examples for aspect models #1056
Conversation
johannsvarela
changed the title
johannsvarela
changed the title
| @@ -293,13 +285,13 @@ Aspect model in GitHub: | |||
| "key": "batchId" | |||
| }, | |||
| { | |||
| "value": "123-0.740-3434-A", | |||
| "key": "manufacturerPartId" | |||
| "key": "manufacturerId", | |||
There was a problem hiding this comment.
Looking at the batch aspect itself, I still see differences between the semantic model example and how we describe it here. What you did is an improvement, for sure: Would you also remove the resulting differences?
I guess this also applies to the other aspect models
There was a problem hiding this comment.
@eckardg regarding the "differences", do you mean changing the examples in the Aspect models?
There was a problem hiding this comment.
Yes, currently when I compare the examples in the aspect models and the examples in the KIT I see differences. Wouldn'it it be easier to adapt the examples in the KIT?
|
Can you state the motivation for removing the |
@arnoweiss the manufactuererPartid is not part of the LocalIdentifier, but is described in the partTypeInformation section below. Therefore the existing example is faulty.
|
@eckardg Unfortunately, we cannot use the same examples from the Aspect models for the KITs because the examples from the Aspect models only allow one example per attribute and therefore no list of examples of arrays such as the LocalIdentifiers, sites, or PartClassification can be generated. If you want, I can harmonize the values from the aspect models with the KIT examples, but the structure in the example in KIT will not be the same as in the apsect models for the reason explained above. Do you get my point? 😄 |
johannsvarela
changed the title
|
@stephanbcbauer @jSchuetz88 Any updates on this PR? When will this bugfix be merged? |
|
There's conflicts. If you resolve those, I can merge immediately. |
There was a problem hiding this comment.
Hi @johannsvarela, thank you for your contribution.
It took me some time to compare your suggestion against the aspect models, but it makes sense to me. Good to go.
Description
This PR fixes bugs in the JSON-Examples for the SerialPart, Batch and JustInSequencePart aspect models of the section Development View / Aspect Models. For more details have a look at the changelog.
The bugfix will affect these KIT versions:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: