Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust audit entity creation #1122

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: adjust audit entity creation #1122

merged 1 commit into from
Nov 11, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Oct 28, 2024

Description

Removed the Expression for new Guid since it wasn't supported from the trigger framework.

Why

The creation of the migration failed due to the audit trigger framework

Issue

Refs: #1121

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 added this to the Release 2.3.0 (24.12) milestone Oct 28, 2024
tfjanjua
tfjanjua approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@tfjanjua tfjanjua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems fine to me, but there is just csharp analyser failing.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit be67c8a into main Nov 11, 2024
11 checks passed
@ntruchsess ntruchsess deleted the bugfix/1121-migrations branch November 11, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfjanjua tfjanjua tfjanjua approved these changes

@ntruchsess ntruchsess ntruchsess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 2.3.0 (24.12)
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @ntruchsess @tfjanjua