Fix BPNL Group validation operators logic #1673
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Fixes some of the existing BPN Group validation operators' scope and proposes the removal of potentially redundant ones.
WHY
Too keep the expected behaviour of some operators, specially the
isAllOf
since was not validating properly (switched the assigned and allowed groups in the validation).FURTHER NOTES
The suggestions are based on expected behaviour (
isAllOf
should check if all the allowed groups are present in the assigned groups) and potential improvements (eq
eneq
could maybe be removed since they do not seem to add much value whenisAllOf
,isAnyOf
andisNoneOf
exist).Changed the
BpnGroupHolder
properties to Sets simply to easily avoid repeated entries.Tests updated accordingly.
Closes #1665