Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BPNL Group validation operators logic #1673

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bmg13
Copy link
Contributor

@bmg13 bmg13 commented Nov 11, 2024

WHAT

Fixes some of the existing BPN Group validation operators' scope and proposes the removal of potentially redundant ones.

WHY

Too keep the expected behaviour of some operators, specially the isAllOf since was not validating properly (switched the assigned and allowed groups in the validation).

FURTHER NOTES

The suggestions are based on expected behaviour (isAllOf should check if all the allowed groups are present in the assigned groups) and potential improvements (eq e neq could maybe be removed since they do not seem to add much value when isAllOf, isAnyOf and isNoneOf exist).

Changed the BpnGroupHolder properties to Sets simply to easily avoid repeated entries.

Tests updated accordingly.

Closes #1665

Copy link

sonarcloud bot commented Nov 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Open
Development

Successfully merging this pull request may close these issues.

Fix BPNL Group Validation Operator's Logic
1 participant