Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do consume messages on the correct thread after resume #5456

Conversation

hadadil
Copy link

@hadadil hadadil commented Jan 23, 2025

Motivation:

In our code we do pause the consumer and later resume it. something as below

consumer.pause();
Uni<Void> processing = ....
processing
.eventually(consumer::resume)
.subscribe()
.with(UniHelper.NOOP);

when we call resume the next msg processed on event loop regardless the consumption meant to be on worker thread based on the Verticle deployment.
Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

@hadadil hadadil changed the title Do consume messages on correct thread after resume Do consume messages on the correct thread after resume Jan 23, 2025
@hadadil
Copy link
Author

hadadil commented Jan 23, 2025

I treid to sign this agreement, but during the registration I am getting

The website encountered an unexpected error. Try again later.

@vietj vietj added this to the 5.0.0 milestone Jan 23, 2025
@vietj
Copy link
Member

vietj commented Jan 23, 2025

try again :-)

@hadadil hadadil force-pushed the do-consume-messages-on-correct-thread-after-resume branch from 733780d to 2201d20 Compare January 23, 2025 17:23
@vietj
Copy link
Member

vietj commented Feb 6, 2025

Recently message consumer implementation message delivery has been reimplemented using the new inbound message channel utility. This concern has been added as a test 59f8f98

@vietj vietj closed this Feb 6, 2025
@vietj vietj removed this from the 5.0.0 milestone Feb 6, 2025
@vietj
Copy link
Member

vietj commented Feb 6, 2025

@hadadil thanks for raising this concern, your test has been integrated and your initial review triggered the reimplementation of message consumer using the inbound message channel we developed and got rid of custom code

@hadadil hadadil deleted the do-consume-messages-on-correct-thread-after-resume branch February 6, 2025 15:09
@hadadil
Copy link
Author

hadadil commented Feb 6, 2025

@vietj thanks for the information.
good to hear that this behavior was already fixed on version 5.0.0 and it's more wonderful now it's covered with a test.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants