Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated additional contract validation error to include ref #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jawaff
Copy link

@jawaff jawaff commented Nov 18, 2024

Motivation:

I started integrating using the newly updated additionalContractFiles feature and was running into an error in some unknown json schema. I could have made my own validation test that did the exact same validation/dereference process as OpenAPIContract, but it makes more sense to just specify which ref is causing the failure in the library.

I don't care what the error says. The only thing that matters to me is that the ref that caused an error shows up in the resulting exception.

Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

@jawaff
Copy link
Author

jawaff commented Nov 18, 2024

The error message is debatable. The error in the test no longer has the Found issue in specification for reference: part, which technically changes behavior a little bit. I can change things up a bit if need be, but I've gotta get back to my other work right now.

@jawaff
Copy link
Author

jawaff commented Nov 18, 2024

I'll fix my email later tonight. It looks like my git config isn't associating my commit with my main email address. That'll clear up the contributor agreement thing.

@pk-work
Copy link
Contributor

pk-work commented Dec 5, 2024

Hi @jawaff thanks for your PR, but I cannot do anything before the ECA check pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants