Add module unit-tests-guava-testlib. #1611
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motlin
force-pushed
the
guava-testlib
branch
2 times, most recently
from
ff2833a
to
74d39e5
Compare
motlin
force-pushed
the
guava-testlib
branch
from
74d39e5
to
72aea6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to run Guava's testlib tests on Eclipse Collections containers. I started with just maps, and this test suite is based on https://github.com/google/guava/blob/master/guava-testlib/src/com/google/common/collect/testing/TestsForMapsInJavaUtil.java.
A few tests fail, just on compute() and merge() methods, and just on edge cases involving replacing nulls.