Implement MutableOrderedMap.toImmutable(). Add ImmutableOrderedMapAdapter. #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motlin
force-pushed
the
ImmutableOrderedMapAdapter
branch
from
bd02dcc
to
0191000
Compare
Good call, I added some tests. I'm finding it tricky to land the changes to improve maps in any order. The massive code review is #1617 and it keeps shrinking as I land other PRs. In the meantime, this PR adds a new feature, but also increases code duplication. All the tests are identical to ones for unmodifiable tests, but the maps are not yet consistent enough to have a single test hierarchy. |
motlin
force-pushed
the
ImmutableOrderedMapAdapter
branch
from
0191000
to
15e5e1b
Compare
motlin
force-pushed
the
ImmutableOrderedMapAdapter
branch
2 times, most recently
from
eb5069d
to
6ee3433
Compare
motlin
force-pushed
the
ImmutableOrderedMapAdapter
branch
from
6ee3433
to
d77af3b
Compare
motlin
dismissed
donraab’s stale review
Stale request for changes, all suggestions incorporated.
motlin
force-pushed
the
ImmutableOrderedMapAdapter
branch
from
d77af3b
to
24442a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.