Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin should not get stuck on files that take JSHint a long time to process #42

Open
johnpeb opened this issue Mar 19, 2013 · 1 comment
Labels

Comments

@johnpeb
Copy link

johnpeb commented Mar 19, 2013

The problem is for large files and sometimes other files, like minified files, the JSHint algorithm will run for a very long time. In the profiler it appears to be taking time inside Rhino.

For minified files, it's probably a problem with JSHint internally. For very large files taking a long time is probably not avoidable.

Here are the desires in decreasing priority

  • When shutting down Eclipse, JSHint must be interruptable so that Eclipse can shut down cleanly
  • JSHint-Eclipse should not be run on files for which it will not finish quickly (by default)

Possible approaches

  • Don't parse files over a certain size (doesn't handle the case for small files that take a long time)
  • Abort parsing a file forcibly after it has been running for 2 minutes (or if the ProgressMonitor has been cancelled) - implementation possibly related to issue Add support for running validation in parallel #36.
@jytou
Copy link

jytou commented Mar 28, 2017

Not sure if it is related, but my eclipse gets stuck with "invoking JSHint Problem Checker" and never ends. After a little while, eclipse becomes totally unresponsive, and I had to kill it several times until I finally removed the project that was causing it problems. It is impressive that it simply killed my eclipse (totally unresponsive until I had to do a kill , restarted and disabled auto-building, deleted project and from now I was safe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants