Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cancelling the builder and add a descriptive name for the builder #35

Merged
merged 2 commits into from
Apr 13, 2013

Conversation

johnpeb
Copy link

@johnpeb johnpeb commented Jan 28, 2013

No description provided.

@ralfstx
Copy link
Member

ralfstx commented Mar 17, 2013

Hi John,

thank you so much for your contribution. Your changes look good to me. Do you think you could come up with a unit test for cancelling the builder? Do you agree to contribute your changes under the terms of the Eclipse Public License?

@johnpeb
Copy link
Author

johnpeb commented Mar 17, 2013

Hi Ralf,
I agree to contribute these changes under the terms of the Eclipse Public License.

@ralfstx
Copy link
Member

ralfstx commented Mar 18, 2013

Hi John,

that's great, thanks. So there's only a unit test missing. We shouldn't
include any untested code. If you could add a test, this would be great. I
won't find the time to do it over next two or three weeks.

Thanks, Ralf

@johnpeb
Copy link
Author

johnpeb commented Mar 18, 2013

Hi Ralf,
We've been testing this code on our internal update site for a few months. It functions as designed. An outstanding issue is if it accidentally starts to process a long file (100K LOC concatenated file) then it's not possible to cancel and Eclipse still has to be killed. Unfortunately I won't be able to write a formal test until I have time to fix that issue.

@FagnerMartinsBrack
Copy link

TL;DR
I suppose he meant because of future regression issues.

@ralfstx
Copy link
Member

ralfstx commented Mar 19, 2013

I have no doubts that your code works as expected. We should have a unit test anyway. Nevermind, I'll add one.

As for the huge JS file, would you mind to open a new issue about that? We might define a (configurable) upper limit for the size of JS files to be checked.

@johnpeb
Copy link
Author

johnpeb commented Mar 19, 2013

Created issue #42

@rombert
Copy link

rombert commented Mar 26, 2013

I'm really interested in this feature as well. Canceling a full workspace build is impossible right now and I need to kill Eclipse which is very inconvenient.

@ralfstx ralfstx merged commit 8206ae6 into eclipsesource:master Apr 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants