Only let specific drag events be defaulted in the pan && zoom handler

eclipsesource · Dec 27, 2024 · 6c65c98 · 6c65c98
1 parent ae0fd1f
commit 6c65c98
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/ui/src/frontend/panel_container.ts b/ui/src/frontend/panel_container.ts
@@ -318,7 +318,7 @@ export class PanelContainer implements m.ClassComponent<Attrs> {
           '.scroll-limiter',
           m('canvas.main-canvas'),
           ),
-      m('.panels', {ondragstart: (e: DragEvent) => e.preventDefault()}, children),
+      m('.panels', children),
     ];
   }
 

diff --git a/ui/src/frontend/track_panel.ts b/ui/src/frontend/track_panel.ts
@@ -432,9 +432,6 @@ export class TrackContent implements m.ClassComponent<TrackContentAttrs> {
             this.mouseDownX = e.layerX;
             this.mouseDownY = e.layerY;
           },
-          ondragstart: (e:DragEvent) => {
-            e.preventDefault();
-          },
           onmouseup: (e: PerfettoMouseEvent) => {
             if (this.mouseDownX === undefined ||
                 this.mouseDownY === undefined) {

diff --git a/ui/src/frontend/viewer_page.ts b/ui/src/frontend/viewer_page.ts
@@ -327,6 +327,11 @@ class TraceViewer implements m.ClassComponent<TraceViewerAttrs> {
                 }
                 globals.makeSelection(Actions.deselect({}));
               },
+              ondragstart: (e :DragEvent)=>{
+                if (!(e.dataTransfer && e.dataTransfer.types.find((format)=>format.startsWith('perfetto/')))) {
+                  e.preventDefault();
+                }
+              },
             },
             m('.pinned-panel-container', m(PanelContainer, {
                 doesScroll: false,