-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new open-source FIELD_API #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great and very much looking forward to switching to the open-source field-api repository! Currently, the NVHPC tests fail to compile field-api and it would be good to get this sorted.
bundle.yml
Outdated
ENABLE_FIELD_API_TESTS=OFF | ||
ENABLE_FIELD_API_FIAT_BUILD=OFF | ||
FIELD_API_UTIL_MODULE_PATH=${CMAKE_SOURCE_DIR}/cloudsc-dwarf/src/common/module | ||
ENABLE_SINGLE_PRECISION=OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is effectively a global option in this form, we might want to simply put this at the top of the bundle.yml.
f2713f2
to
72ca253
Compare
Thanks for the review @reuterbal and for all the offline discussion. I am converting this to a draft since I will need a FIELD_API build-system update to get around building with |
d618af0
to
4d3e726
Compare
4d3e726
to
d66b5f5
Compare
Thanks again @reuterbal for all the help with this. The CI now builds the nvhpc runs with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a reasonable solution retaining coverage for some variants built with nvhpc and testing at least the build for the others. Many thanks for grinding through this!
As discussed: Merging now and let's have a 1-line change PR once the new FIELD_API version has been tagged! |
This PR updates the scc-field variant to use the new open-source FIELD_API. Notable changes are the use of the
FieldGang
feature to offload packed fields as a single contiguous entity, and the use of raw device pointers rather than host-mapped device pointers.