Make un-confirmation more clear

edan-bainglass · Nov 5, 2024 · 006bd5a · 006bd5a
1 parent 443593a
commit 006bd5a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/aiidalab_qe/app/configuration/advanced/model.py b/src/aiidalab_qe/app/configuration/advanced/model.py
@@ -230,7 +230,7 @@ def _link_model(self, model: AdvancedSubModel):
             (model, "override"),
         )
         model.observe(
-            self.unconfirm,
+            self._unconfirm,
             tl.All,
         )
         for trait in model.dependencies:

diff --git a/src/aiidalab_qe/common/mixins.py b/src/aiidalab_qe/common/mixins.py
@@ -83,6 +83,9 @@ def confirm(self):
         self.confirmed = True
 
     @tl.observe(tl.All)
-    def unconfirm(self, change=None):
+    def _on_any_change(self, change):
         if change and change["name"] != "confirmed":
-            self.confirmed = False
+            self._unconfirm()
+
+    def _unconfirm(self):
+        self.confirmed = False