More careful treatment of NA values prior to CCTZ call #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsilvest
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @trevorld and discussed quite extensively in issue 45 of the RcppCCTZ repo, CRAN found an UBSAN warning in his package (that uses our pair of packages.
This PR modifies the behavior in the formatting helper (seen the in callstack in that report) slightly in that it identifies possible NA values and sets them to non-NA before calling CCTZ and then flags the corresponding results as NA. This allows use to continue to use 'non-standard' (in the IEEE sense) NA flags in characters (and ints and ... as R does) without tickling CCTZ. We may want to look into dealing with it in RcppCCTZ in some places too, and there may be others here.