Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Plays some characters are in #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prig9951
Copy link

@prig9951 prig9951 commented Feb 7, 2020

Hi Terence,

I made a pull request for the fixes I in the character table as per the email I sent you.

email was
I discovered a total of 5 incorrect works field in the character table these were

blunt is henry4p1,henry4p2 Should be henry4p1
EdmundMortimer is henry6p1,henry6p3 Should be henry6p1
falstaff is henry4p1,henry4p2,henry5,merrywives Should be henry4p1,henry4p2,merrywives
SirWilliamStanley is henry6p3,richard3 Should be richard3
westmoreland is henry4p1,henry4p2,henry5,henry6p3 Should be henry4p1,henry4p2,henry5

I found this out by creating these views

Create or Replace view charidworkid as (select distinct CharID, WorkID from Paragraphs order by CharID, WorkID);

Create or Replace view charidworkidgroup as (select CharID, REGEXP_REPLACE(REPLACE(GROUP_CONCAT(WorkID,','),',,',','),',$','') Works from charidworkid group by CharID);

and then running the following script

select c.CharID , c.Works, g.Works, IF(c.Works = g.Works,'Match','Might Match') 'Match' , IF(LENGTH(c.Works) = LENGTH(g.Works),'Match Length','NO Match') 'LengthMatch' from Characters c, charidworkidgroup g where c.CharID = g.CharID and c.CharID <> 'xxx' order by IF(c.Works = g.Works,'Match','No Match'), IF(LENGTH(c.Works) = LENGTH(g.Works),'Match Length','NO Match');

@edent
Copy link
Owner

edent commented Feb 7, 2020

Thanks for this pull request. A few points to note...

Blunt - he does appear in Henry IV pt2

Enter PRINCE JOHN OF LANCASTER, WESTMORELAND, BLUNT, and others

and then

Exeunt BLUNT and others with COLEVILE
He literally enters, exits, then is killed offstage.

Edmund Mortimer is in Henry VI p3

Exeunt YORK, EDWARD, EDMUND, GEORGE, RICHARD, WARWICK, NORFOLK, MONTAGUE, their Soldiers, and Attendants

Yup. He leaves the stage - having never appeared.

Falstaff is mentioned extensively in Henry V - see https://en.wikipedia.org/wiki/Falstaff#Henry_V

Sir William Stanley enters and is spoken about in Henry 6 pt3

SCENE V. A park near Middleham Castle In Yorkshire.
Enter GLOUCESTER, HASTINGS, and STANLEY
GLOUCESTER
Now, my Lord Hastings and Sir William Stanley,

Westmoreland does appear in H6 pt3 as

('henry6p3', 643710, 67, 'EarlWestmoreland-h63', 'What, shall we suffer this? let''s pluck him down:\nMy heart for anger burns; I cannot brook it.', 1, 1),

So, I think this PR needs a few changes. It should just be:

  • Remove Falstaff from Henry V
  • Either remove the duplicate Westmoreland, or merge with the existing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants