Dev (#44)

* refactor: improve CL * fix: widget dynamic props * core: v1.1.1
edgarberm · Jun 12, 2024 · 6c5afbb · 6c5afbb
1 parent 609f0df
commit 6c5afbb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/.github/workflows/gh-pages.yml b/.github/workflows/gh-pages.yml
@@ -62,7 +62,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: 20
           cache: 'npm'
       - name: Install dependencies
         run: npm install
@@ -73,4 +73,4 @@ jobs:
       - name: Run Storybook tests
         run: npm run test:storybook
         env:
-          TARGET_URL: 'https://builtbyedgar.github.io/dashup/'
+          TARGET_URL: 'https://edgarberm.github.io/dashup/'
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "dashup",
-  "version": "1.0.10",
+  "version": "1.1.1",
   "description": "A React Dashboard Component.",
   "repository": {
     "type": "git",
@@ -39,10 +39,6 @@
     "sortable",
     "resizable"
   ],
-  "engines": {
-    "node": ">=18",
-    "npm": ">=9"
-  },
   "peerDependencies": {
     "react": "^18.2.0",
     "react-dom": "^18.2.0"

diff --git a/src/components/Widget.tsx b/src/components/Widget.tsx
@@ -110,7 +110,7 @@ export default function Widget({
         resizer?.removeEventListener('mousedown', handleResizeEvents, false)
       }
     }
-  }, []) // eslint-disable-line react-hooks/exhaustive-deps
+  }, [draggable, fixed, resizable]) // eslint-disable-line react-hooks/exhaustive-deps
 
   /**
    * When the necessary properties change, we recalculate the new styles and render the component.

diff --git a/stories/Dashboard.stories.tsx b/stories/Dashboard.stories.tsx
@@ -564,8 +564,8 @@ export const ToolbarWithOptionsWidget: Story = {
         </>
       )
       CUSTOM_OPTIONS_WIDGET.dragHandleClassName = 'custom-draggable-toolbar'
-      const WS = [...FILTER, CUSTOM_OPTIONS_WIDGET]
-      const [widgets, setWidgets] = useState(WS)
+      const [widgets, setWidgets] = useState([...FILTER, CUSTOM_OPTIONS_WIDGET])
+
       const handleChange = (dashboard: Layout) => {
         setWidgets(dashboard)
       }
@@ -574,6 +574,7 @@ export const ToolbarWithOptionsWidget: Story = {
         // eslint-disable-next-line no-console
         console.log(`You fired the action for widget: \n ${id}`)
       }
+
       function handleRemove(id: string) {
         const newWidgets = widgets.filter((w) => w.id !== id)
         setWidgets(newWidgets)