Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: update failure response structure for /api/v2/sign-quote endpoint #675

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

daniel-weisse
Copy link
Member

Proposed changes

  • By default, set the Message field for failure status responses
  • On failure for /api/v2/sign-quote, set the Data field to {"sgxQuote": "<verify error>"}

@daniel-weisse daniel-weisse requested a review from thomasten June 14, 2024 13:22
Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for marblerun-docs ready!

Name Link
🔨 Latest commit 672540d
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/666c44111ef92d0008d256f5
😎 Deploy Preview https://deploy-preview-675--marblerun-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daniel-weisse daniel-weisse merged commit 211d293 into master Jun 17, 2024
9 of 10 checks passed
@daniel-weisse daniel-weisse deleted the ref/clientapi/sign-failure branch June 17, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants