Support injection of Coordinator root and intermediate certificates into Marble environment #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marblerun-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
daniel-weisse
force-pushed
the
dw/coordinator-root-template
branch
from
97330a2 to
17ecbb5
Compare
daniel-weisse
changed the title
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
dw/coordinator-root-template
branch
from
17ecbb5 to
89e7cb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
/coordinator/core/marblerapi.goAdditional info
The same thing can be done for Fix Marble verification with Coordinator root certificate #782 to support injecting the Coordinator's intermediate certificate. I can also wait until that PR is merged and then apply the required changes here, so we have them grouped in one PRAdded