Feature/typed array support #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work! |
|
Do we really need 'normalizeNoTyped' anymore? Do you have any information on which iOS/Android versions are likely to not have support for typed arrays? |
|
I see that this is merged, but I'm not seeing it as released to npm. Could we get a new release on npm that includes this? |
|
@rumbcam Sorry about that, the new release 1.0.2 has now been published on npm. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's much more efficient to use typed arrays when possible for things like audio -- this PR detects if typed arrays are available and uses them if they are. Since typed arrays have all the same features as normal arrays (and then some) this shouldn't break anything but for anyone who is using the advanced features (particularly if they are normalizing the audio) this will make a significant improvement, saving a lot of unneeded copying of data.