Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node version in CI and deps #380

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Update Node version in CI and deps #380

merged 2 commits into from
Jan 30, 2025

Conversation

xuhdev
Copy link
Member

@xuhdev xuhdev commented Jan 30, 2025

Please fill in this template.

  • Use a meaningful title for the pull request.
  • Use meaningful commit messages.
  • Run tsc w/o errors (same as npm run compile).
  • Run npm run lint w/o errors.

@xuhdev xuhdev changed the title Update Node version Update Node version in CI and deps Jan 30, 2025
@xuhdev xuhdev merged commit 01c88ce into main Jan 30, 2025
3 checks passed
@xuhdev xuhdev deleted the node branch January 30, 2025 00:46
@xuhdev xuhdev mentioned this pull request Jan 30, 2025
4 tasks
@SunsetTechuila
Copy link

@xuhdev I suggest to test on Node 18 and 20 too, because the latest VSCode uses Node 20 and 18 is still supported

also, instead of updating glob I would replace it with the fast-glob package, as it is much lighter

@SunsetTechuila
Copy link

SunsetTechuila commented Jan 30, 2025

and I would rather pin versions of Node and VSCode types to the oldest supported by the extension

@xuhdev
Copy link
Member Author

xuhdev commented Jan 30, 2025

@xuhdev I suggest to test on Node 18 and 20 too, because the latest VSCode uses Node 20 and 18 is still supported

PRs are welcome!

also, instead of updating glob I would replace it with the fast-glob package, as it is much lighter

It probably doesn't matter because it's only used in tests. I would avoid touching this part because I'm not familiar with the codebase just to avoid causing unexpected behaviors, and everything works well now (:

@xuhdev
Copy link
Member Author

xuhdev commented Jan 30, 2025

and I would rather pin versions of Node and VSCode types to the oldest supported by the extension

I agree, PRs are welcome.

@SunsetTechuila
Copy link

I switched to fast-glob in #375 and didn't run into any issues 🤷🏿‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants