Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-19 clarified leading slash in the spec #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GH-19 clarified leading slash in the spec #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,12 @@ special characters for wildcard matching:
If the glob contains a path separator (a ``/`` not inside square brackets), then the glob is relative
to the directory level of the particular `.editorconfig` file itself.
Otherwise the pattern may also match at any level below the `.editorconfig`
level. For example, ``*.c`` matches any file that ends with ``.c`` in the
level.

Therefore, similar to a `gitignore format`_, a leading slash is not relevant if there is already a slash in the middle of the pattern.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should mention gitignore here, lest people think that editorconfig files have the same semantics as gitignore files.

Suggested change
Therefore, similar to a `gitignore format`_, a leading slash is not relevant if there is already a slash in the middle of the pattern.
Therefore, a leading slash is not relevant if there is already a slash in the middle of the pattern.

Thus, the globs `/subdir/*.c` and `subdir/*.c` must yield the same result.

For example, ``*.c`` matches any file that ends with ``.c`` in the
directory of ``.editorconfig`` or any other directory below one that stores this ``.editorconfig``.
However, the glob ``subdir/*.c`` only matches files that end
with ``.c`` in the ``subdir`` directory in the directory of ``.editorconfig``.
Expand Down Expand Up @@ -400,3 +405,4 @@ this specification.
.. _plugin-tests repository: https://github.com/editorconfig/editorconfig-plugin-tests
.. _Semantic Versioning 2.0.0: https://semver.org/spec/v2.0.0.html
.. _specification repository: https://github.com/editorconfig/specification
.. _gitignore format: https://git-scm.com/docs/gitignore#_pattern_format
Loading