-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add language support: Traditional Chinese. #55
base: master
Are you sure you want to change the base?
Conversation
@eggheadgames I'm just confused with the CircleCI error. How could I fix that? I'm willing to do the work. 💪 |
@samuelchou Sorry for the slow response. My guess is that the CircleCi configuration needs to be updated for their version 2. I.e. similar to this change: If you have some time to do that, it is much appreciated! |
Interesting...CircleCI failed at.... uh, unexpectedly.
If that was what I think, gradle source seems to be out-dated...? |
Ok...there are more gradle problems than I expected. I'll try to fix it by the way.
|
After I tried updating
And it seems that I don't know man, the fix seems like a HUGE work to the code, and it might be inappropriate to be done in this pull request...? |
This reverts commit b72d5dc.
Since I now feel it's a disaster to upgrade gradle... 😭 |
@samuelchou Sorry for the hassle. I went through most of this same stuff with the https://github.com/eggheadgames/android-about-box/ when I updated it to work with current versions of Android Studio and new releases of Android. There may be some clues there, as the projects were started around the same time and set up the same way. Unfortunately, I don't use Siren in my Android apps any longer, so I wasn't forced to update it at the same time. It looks like you're making steady progress. You might want to check the |
I'm trying to add Chinese(Traditional) support. It should be a easy fix...