Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dev mode support custom asset url host #38

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hubcarl
Copy link

@hubcarl hubcarl commented Aug 15, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Add unit test for follow PR:

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          196       198    +2     
=========================================
+ Hits           196       198    +2     
Impacted Files Coverage Δ
config/config.default.js 100.00% <ø> (ø)
app.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb5f41...6aa47a4. Read the comment docs.

@hubcarl hubcarl marked this pull request as ready for review August 24, 2020 01:46
app.js Outdated Show resolved Hide resolved
@atian25 atian25 requested a review from popomore August 24, 2020 02:01
@atian25 atian25 changed the title Feature: dev mode support custom asset url host feat: dev mode support custom asset url host Aug 24, 2020
@hubcarl
Copy link
Author

hubcarl commented Aug 27, 2020

@popomore need review, then publish

@big-camel
Copy link

这。。。唉。。。

@big-camel
Copy link

为啥不合并呢,在开发时,想用手机访问开发环境只能硬编码了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants