Extractor that removes dead code in if inputs #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems to time out |
oflatt
force-pushed
the
oflatt-dead-code-aware-extractor
branch
from
7a3f541 to
df21ada
Compare
oflatt
force-pushed
the
oflatt-dead-code-aware-extractor
branch
from
c77aefb to
9300d42
Compare
yihozhang
approved these changes
Feb 7, 2025
| let mut node_to_type: IndexMap<ClassId, Type> = Default::default(); | ||
|
|
||
| for (term, node_id) in &self.correspondence { | ||
| for (term, node_id) in &self.correspondence.clone() { |
There was a problem hiding this comment.
Is compute_eclass_types only called once so this clone is acceptable? Can we get rid of this clone?
There was a problem hiding this comment.
good question, but probably not blocking
busy writing paper!
|
Doesn't make the nightly numbers better but does help with Anjali's examples in the overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a special case to the extractor that adds "DeadCode" nodes to the resulting AST
Then, a new pass removes these dead code expressions
It also adds typechecking between compiler passes to catch more bugs