Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide OMD, RPOTS, LOWQ2 errors for single particle simulations #1716

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Jan 21, 2025

Briefly, what does this PR introduce?

This removes the endless No beam protons to choose matrix!! Skipping!! warnings which are clogging up the logs and hiding real issues. Do the same with the warnings about missing beam electrons.

What kind of change does this PR introduce?

  • Bug fix (issue: don't emit errors on every event when there's nothing wrong)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc requested review from a team and rahmans1 and removed request for a team January 21, 2025 02:46
@wdconinc
Copy link
Contributor Author

FYI @rahmans1 You can likely also benefit from this for singles productions.

@wdconinc
Copy link
Contributor Author

Not sure why it is setting parameters incorrectly, see https://github.com/eic/EICrecon/actions/runs/12880836546/job/35910542823?pr=1716#step:8:4553

@wdconinc
Copy link
Contributor Author

@wdconinc wdconinc changed the title fix: hide OMD and RPOTS errors for single particle simulations fix: hide OMD, RPOTS, LOWQ2 errors for single particle simulations Jan 21, 2025
@wdconinc
Copy link
Contributor Author

wdconinc commented Jan 21, 2025

  • apply to more LOWQ2 algorithms and factories
  • fix the EcalLumiSpec job

@wdconinc
Copy link
Contributor Author

Ignoring iwyu suggestion of stdlib.h in https://github.com/eic/EICrecon/actions/runs/12892630096/job/35947501724?pr=1716 since it is addressed by #1703.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant