Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-eic-shell.yml: update list of supported releases #1735

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 12, 2025

Briefly, what does this PR introduce?

As discussed in #1705, this is dropping a check for whether EICrecon compiles on 24.04.0-stable. The earliest checked version will now be 24.09.0-stable.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@veprbl veprbl requested review from a team and wdconinc and removed request for a team February 13, 2025 01:17
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One side effect of more test platforms is that we are more likely to be unable to take advantage of ccache. I think we can't run this many platforms without evicting the first ccache by the time we write the last platforms's ccache ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants