Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update multisig-prover with latest rkyv crate API updates #33

Merged
merged 36 commits into from
Aug 12, 2024
Merged

feat: update multisig-prover with latest rkyv crate API updates #33

merged 36 commits into from
Aug 12, 2024

Conversation

eloylp
Copy link
Member

@eloylp eloylp commented Jul 29, 2024 •
edited
Loading

Referenced issue
Part of https://github.com/eigerco/solana-axelar-internal/issues/372

Description

It just updates few public API breaking changes we did at https://github.com/eigerco/solana-axelar-internal/pull/369. Basically, now signatures are requiring to specify the hasher implementation. More info in the linked pull-request and linked issue.

Reviewer recommendations

Since this changes were already approved and merged in the rkyv crate, i think the validity of the code could be checked by just doing a cargo test in the root of the repository.

The only commit that needs to be reviewed is 6e80906

cgorenflo and others added 30 commits July 16, 2024 13:18
@cgorenflo
chore: use different rust caches for each ci check (axelarnetwork#518)
7e878bb
@cgorenflo
chore: force cosmwasm-check install for build wasm release check (axe…
938c5cf 
…larnetwork#519)
@haiyizxx @cgorenflo
fix(multisig-prover): drop checksum check for destination chain (axel…
ed0327d 
…arnetwork#513)

Co-authored-by: Christian Gorenflo <[email protected]>
chore: release ampd 0.6.0 [skip ci]
5152aec
@cgorenflo
feat(gateway): add permission control to gateway (axelarnetwork#508)
9c7990b
@maancham
refactor(minor-integration-tests): use rewards query for contract wra…
681af1f 
…pper creation (axelarnetwork#511)
@haiyizxx @cgorenflo
feat(minor-voting-verifier): query poll by id (axelarnetwork#505)
e4220a6 
Co-authored-by: Christian Gorenflo <[email protected]>
@cgorenflo
feat(rewards): add permission control to rewards contract (axelarnetw…
7a53c19 
…ork#517)
@cgorenflo
chore: give github workflows more fitting names (axelarnetwork#520)
7393fa4
@talalashraf
chore(infra): log crates.toml to figure out issues with caching and u…
d896952 
…se blacksmith rust-cache 3.0.1 (axelarnetwork#516)
chore: release router 0.4.0 [skip ci]
f8a7fe7
@cjcobb23 @milapsheth
chore: update compatibility matrix (axelarnetwork#521)
c1e80ca 
Co-authored-by: Milap Sheth <[email protected]>
@fish-sammy
feat(ampd): integrate ampd queued broadcaster with the axelar batch r…
600f247 
…equest (axelarnetwork#474)
@maancham
feat(minor-ampd): make handle sleep and max_attempts parameters confi…
596b214 
…gurable (axelarnetwork#510)
@talalashraf
revert: chore: force cosmwasm-check install for build wasm release ch…
a7f3b99 
…eck (axelarnetwork#519) (axelarnetwork#522)
@cgorenflo
chore(fmt): enforce unique import sorting in PR checks (axelarnetwork…
deab56a 
…#524)
@maancham
docs: add bullet points to all chapters of SUMMARY.md (axelarnetwork#529
ac966f1 
)
@cgorenflo
feat(multisig-prover): add permission control to multisig-prover (axe…
546b5e1 
…larnetwork#526)
@cgorenflo
feat: return structured errors from contracts (axelarnetwork#527)
638454c
@cgorenflo
feat(minor): add legacy (uppercase) chain name support (axelarnetwork…
7a7f9bf 
…#523)
@cgorenflo
feat(nexus-gateway): add permission control to nexus-gateway (axelarn…
8ee688f 
…etwork#530)
@maancham
refactor: remove unnecessary allow dead_code flags (axelarnetwork#531)
c5e8bef
@cgorenflo
feat(minor-voting-verifier): add permission control to the voting-ver…
b4cf22f 
…ifier (axelarnetwork#536)
@cgorenflo
feat(service-registry): add permission control to the service-registry (
b93c3db 
axelarnetwork#535)
@fish-sammy
revert(ampd): revert "integrate ampd queued broadcaster with the axel…
febb75b 
…ar batch request (axelarnetwork#474)" (axelarnetwork#540)
@cgorenflo
refactor(minor): make the main flow msgs consistent (axelarnetwork#539)
e4ef307
@cgorenflo
refactor(minor): remove "get" from function names (axelarnetwork#537)
216f153
@milapsheth @cgorenflo
ci: use cosmwasm-check v1.3.x for consistency with wasmvm version (ax…
7e27cb7 
…elarnetwork#534)

Co-authored-by: Christian Gorenflo <[email protected]>
@milapsheth
ci(ampd): build ampd in gh actions (axelarnetwork#533)
3359fc3
@milapsheth
fix(minor-router): unambiguous message hash computation (axelarnetwor…
852e68b 
…k#542)
@eloylp eloylp changed the base branch from main to solana July 29, 2024 16:26
@eloylp eloylp requested a review from Chxpz July 29, 2024 16:33
@eloylp eloylp marked this pull request as ready for review July 29, 2024 16:33
@eloylp eloylp self-assigned this Jul 29, 2024
@eloylp
Copy link
Member Author

eloylp commented Jul 30, 2024 •
edited
Loading

This branch carries latest upstream changes from main 1a1f072 , this should be a merge commit, not squash.

roberts-pumpurs
roberts-pumpurs approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@roberts-pumpurs roberts-pumpurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although I only reviewed 6e80906

@eloylp eloylp merged commit 08c4878 into solana Aug 12, 2024
1 of 6 checks passed
@eloylp eloylp deleted the update-rkyv-multisig branch August 12, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberts-pumpurs roberts-pumpurs roberts-pumpurs approved these changes

@Chxpz Chxpz Awaiting requested review from Chxpz

Assignees

@eloylp eloylp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@eloylp @roberts-pumpurs @cgorenflo @haiyizxx @maancham @talalashraf @cjcobb23 @fish-sammy @milapsheth