Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: feedback react #59

Merged
merged 10 commits into from
Feb 7, 2025
Merged

chore: feedback react #59

merged 10 commits into from
Feb 7, 2025

Conversation

eloylp
Copy link
Member

@eloylp eloylp commented Feb 3, 2025

This PR reacts to feedback received in the upstream PR , since some changes were introduced in the way we scan the logs, an additional PR pointing to the solana one is needed (this one).

@eloylp eloylp changed the title feedback react feat: feedback react Feb 5, 2025
@eloylp eloylp changed the title feat: feedback react chore: feedback react Feb 5, 2025
@eloylp eloylp marked this pull request as ready for review February 5, 2025 19:46
@eloylp eloylp self-assigned this Feb 5, 2025
Copy link
Member

@roberts-pumpurs roberts-pumpurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointed out some low hanging fruits for optimizations. But the logic seems solid! 👍

ampd/src/solana/mod.rs Outdated Show resolved Hide resolved
ampd/src/solana/mod.rs Outdated Show resolved Hide resolved
ampd/src/solana/mod.rs Outdated Show resolved Hide resolved
ampd/src/solana/mod.rs Outdated Show resolved Hide resolved
@eloylp eloylp merged commit 865a924 into solana Feb 7, 2025
1 of 6 checks passed
@eloylp eloylp deleted the feedback-react branch February 7, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants