Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restructure pallet part 1, unit tests and internal mockup #154

Merged
merged 1 commit into from
Mar 1, 2024
Merged

chore: restructure pallet part 1, unit tests and internal mockup #154

merged 1 commit into from
Mar 1, 2024

Conversation

neutrinoks
Copy link
Contributor

  • moved tests into src; mock.rs and assets.rs were combined and also moved to src
  • in test balance applied macros script_transaction and no_type_args and ExtBuilder`

@neutrinoks neutrinoks requested a review from Rqnsom February 27, 2024 12:14
@neutrinoks neutrinoks self-assigned this Feb 27, 2024
@neutrinoks neutrinoks force-pushed the chore/restructure-pallet branch from 7083154 to af8bc17 Compare February 27, 2024 12:46
Rqnsom
Rqnsom previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/tests/balance.rs Outdated Show resolved Hide resolved
@neutrinoks neutrinoks force-pushed the chore/restructure-pallet branch 8 times, most recently from 83d4d67 to 16d2ea1 Compare February 29, 2024 15:53
@neutrinoks neutrinoks marked this pull request as ready for review February 29, 2024 15:53
@neutrinoks neutrinoks requested review from Rqnsom and asmie February 29, 2024 15:54
asmie
asmie previously approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@asmie asmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

src/mock.rs Outdated Show resolved Hide resolved
src/tests/modules.rs Outdated Show resolved Hide resolved
@neutrinoks neutrinoks force-pushed the chore/restructure-pallet branch from 16d2ea1 to 5216942 Compare March 1, 2024 09:05
@neutrinoks neutrinoks force-pushed the chore/restructure-pallet branch from 5216942 to b96a8dd Compare March 1, 2024 09:06
@neutrinoks neutrinoks merged commit 4536e8e into feat/main-milestone-three Mar 1, 2024
1 check passed
@neutrinoks neutrinoks deleted the chore/restructure-pallet branch March 1, 2024 09:26
neutrinoks added a commit that referenced this pull request Mar 25, 2024
@neutrinoks
chore: restructure pallet part 1, unit tests and internal mockup (#154)
3d7bb33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmie asmie asmie approved these changes

@Rqnsom Rqnsom Awaiting requested review from Rqnsom

Assignees

@neutrinoks neutrinoks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neutrinoks @asmie @Rqnsom