Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restructure pallet part 2, workspace manifest file #156

Merged
merged 1 commit into from
Mar 1, 2024
Merged

chore: restructure pallet part 2, workspace manifest file #156

merged 1 commit into from
Mar 1, 2024

Conversation

neutrinoks
Copy link
Contributor

  • The original crate pallet-move is now moved to subdirectory pallet
  • The RPC is now in subdirectory rpc
  • The pallet's runtime API is moved into the pallet directly
  • Added a workspace manifest file and centralized dependencies
  • All related definitions and re-exports related to the former runtime-API are now within pallet_move::api

@neutrinoks neutrinoks requested review from asmie and Rqnsom March 1, 2024 14:10
@neutrinoks neutrinoks self-assigned this Mar 1, 2024
@neutrinoks neutrinoks force-pushed the chore/restructure-pallet-part-2 branch from 53ba863 to 6c02c3e Compare March 1, 2024 15:42
Rqnsom
Rqnsom approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for @asmie's approval as well

asmie
asmie approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@asmie asmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neutrinoks neutrinoks merged commit f42e934 into feat/main-milestone-three Mar 1, 2024
1 check passed
@neutrinoks neutrinoks deleted the chore/restructure-pallet-part-2 branch March 1, 2024 16:14
neutrinoks added a commit that referenced this pull request Mar 25, 2024
@neutrinoks
chore: restructure pallet part 2, workspace manifest file (#156)
8f2f624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmie asmie asmie approved these changes

@Rqnsom Rqnsom Rqnsom approved these changes

Assignees

@neutrinoks neutrinoks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neutrinoks @asmie @Rqnsom