Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement clean up mechanism and add unit tests #157

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat: implement clean up mechanism and add unit tests #157

merged 1 commit into from
Mar 7, 2024

Conversation

neutrinoks
Copy link
Contributor

@neutrinoks neutrinoks commented Mar 5, 2024 •
edited
Loading

  • implemented hook on_idle as a clean-up mechanism for old multi-sign requests
  • added two unit tests for multi-signing situations with event-checking
  • restored state of unit tests with eight signers and updated them to the current state of development

@neutrinoks neutrinoks requested review from asmie and Rqnsom March 5, 2024 12:40
@neutrinoks neutrinoks self-assigned this Mar 5, 2024
@neutrinoks neutrinoks force-pushed the feat/multi-signer-hook-and-tests branch 7 times, most recently from ee6e703 to 0b3e756 Compare March 6, 2024 14:53
Rqnsom
Rqnsom reviewed Mar 6, 2024
View reviewed changes
pallet/src/lib.rs Outdated Show resolved Hide resolved
Rqnsom
Rqnsom reviewed Mar 6, 2024
View reviewed changes
pallet/src/signer.rs Outdated Show resolved Hide resolved
pallet/src/signer.rs Outdated Show resolved Hide resolved
pallet/src/tests/signer.rs Show resolved Hide resolved
pallet/src/tests/signer.rs Show resolved Hide resolved
Rqnsom
Rqnsom reviewed Mar 6, 2024
View reviewed changes
pallet/src/tests/signer.rs Outdated Show resolved Hide resolved
pallet/src/tests/signer.rs Show resolved Hide resolved
pallet/src/tests/signer.rs Outdated Show resolved Hide resolved
pallet/src/tests/signer.rs Show resolved Hide resolved
pallet/src/tests/signer.rs Show resolved Hide resolved
Rqnsom
Rqnsom previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@neutrinoks neutrinoks force-pushed the feat/multi-signer-hook-and-tests branch 2 times, most recently from 8fb731e to b61bb38 Compare March 7, 2024 11:43
@neutrinoks neutrinoks force-pushed the feat/multi-signer-hook-and-tests branch from b61bb38 to 2f8c548 Compare March 7, 2024 11:47
Rqnsom
Rqnsom approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neutrinoks neutrinoks merged commit 09edbf0 into feat/main-milestone-three Mar 7, 2024
1 check passed
@neutrinoks neutrinoks deleted the feat/multi-signer-hook-and-tests branch March 7, 2024 12:00
neutrinoks added a commit that referenced this pull request Mar 25, 2024
@neutrinoks
feat: implement clean up mechanism and add unit tests (#157)
3f70731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rqnsom Rqnsom Rqnsom approved these changes

@asmie asmie Awaiting requested review from asmie

Assignees

@neutrinoks neutrinoks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoks @Rqnsom