Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement on_sector_terminate #101

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Implement on_sector_terminate #101

merged 5 commits into from
Jul 4, 2024

Conversation

jmg-duarte
Copy link
Contributor

Description

Implement the on_sector_terminate function

Important points for reviewers

Original implementation: https://github.com/filecoin-project/builtin-actors/blob/54236ae89880bf4aa89b0dba6d9060c3fd2aacee/actors/market/src/lib.rs#L786-L876

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • If there are follow-ups, have you created issues for them?
    • If yes, which ones? / List them here
  • Have you tested this solution?
  • Were there any alternative implementations considered?
  • Did you document new (or modified) APIs?

@jmg-duarte jmg-duarte changed the base branch from develop to feat/11/market-pallet-activate-deals June 26, 2024 16:13
@th7nder th7nder mentioned this pull request Jun 27, 2024
Closed
@jmg-duarte jmg-duarte self-assigned this Jun 27, 2024
@th7nder th7nder force-pushed the feat/11/market-pallet-activate-deals branch from 6242b9f to d8823d0 Compare June 28, 2024 05:10
Base automatically changed from feat/11/market-pallet-activate-deals to develop June 28, 2024 10:18
@jmg-duarte jmg-duarte force-pushed the feat/11/market-pallet-sector-terminate branch 2 times, most recently from 3708065 to 08d4c49 Compare July 1, 2024 16:04
@jmg-duarte jmg-duarte marked this pull request as ready for review July 1, 2024 16:05
@jmg-duarte jmg-duarte added the ready for review Review is needed label Jul 1, 2024
@jmg-duarte jmg-duarte force-pushed the feat/11/market-pallet-sector-terminate branch from 08d4c49 to 41a17f1 Compare July 1, 2024 16:06
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jul 1, 2024
th7nder
th7nder requested changes Jul 2, 2024
View reviewed changes
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Show resolved Hide resolved
pallets/market/src/lib.rs Show resolved Hide resolved
pallets/market/src/test.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/test.rs Show resolved Hide resolved
th7nder
th7nder requested changes Jul 3, 2024
View reviewed changes
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
@th7nder th7nder mentioned this pull request Jul 3, 2024
Merged
8 tasks
@jmg-duarte jmg-duarte force-pushed the feat/11/market-pallet-sector-terminate branch from 2a51319 to b9a08eb Compare July 3, 2024 16:48
th7nder
th7nder requested changes Jul 3, 2024
View reviewed changes
primitives/proofs/src/traits.rs Outdated Show resolved Hide resolved
@jmg-duarte jmg-duarte force-pushed the feat/11/market-pallet-sector-terminate branch from 25563d2 to a587e6d Compare July 4, 2024 08:54
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jul 4, 2024
@jmg-duarte jmg-duarte force-pushed the feat/11/market-pallet-sector-terminate branch from 4765752 to 24a7f2c Compare July 4, 2024 09:02
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jul 4, 2024
th7nder
th7nder requested changes Jul 4, 2024
View reviewed changes
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
th7nder
th7nder previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pooookinator is on fire!

cernicc
cernicc previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits. Good work 💪

pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
@jmg-duarte jmg-duarte dismissed stale reviews from cernicc and th7nder via 6af726d July 4, 2024 12:45
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jul 4, 2024
th7nder
th7nder previously approved these changes Jul 4, 2024
View reviewed changes
cernicc
cernicc previously approved these changes Jul 4, 2024
View reviewed changes
@jmg-duarte jmg-duarte enabled auto-merge July 4, 2024 12:49
@jmg-duarte jmg-duarte dismissed stale reviews from cernicc and th7nder via 6d6d0b7 July 4, 2024 13:40
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jul 4, 2024
@jmg-duarte jmg-duarte mentioned this pull request Jul 4, 2024
Merged
7 tasks
@jmg-duarte jmg-duarte merged commit b0205d0 into develop Jul 4, 2024
3 checks passed
@jmg-duarte jmg-duarte deleted the feat/11/market-pallet-sector-terminate branch July 4, 2024 14:55
@th7nder th7nder mentioned this pull request Jul 12, 2024
Closed
@th7nder th7nder mentioned this pull request Aug 26, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th7nder th7nder th7nder approved these changes

@cernicc cernicc cernicc approved these changes

@serg-temchenko serg-temchenko Awaiting requested review from serg-temchenko

@aidan46 aidan46 Awaiting requested review from aidan46

Assignees

@jmg-duarte jmg-duarte

Labels
ready for review Review is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmg-duarte @cernicc @th7nder