feat(Dockerfile): add docker file for the storage provider #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1792502.
5 tasks
th7nder
requested changes
Jul 8, 2024
|
The questions I left in the other PR still apply |
th7nder
previously requested changes
Jul 8, 2024
cernicc
added
ready for review
jmg-duarte
requested changes
Jul 9, 2024
cernicc
added
ready for review
aidan46
approved these changes
Jul 9, 2024
cernicc
added
ready for review
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Dockerfile and readme for how to run the storage server.
Important points for reviewers
The Dockerfile is not part of the build process. The idea is that for the community we should "manually" build the image and then upload that to some public image repository. The best solution would be if we build the image as part of our ci process and then add the image as the artifact of the repository. But the thing is that until the repo is private that image can't be exposed to the community.
cargo-chefis used to enable docker layer caching.Checklist