test(runtime): configure lower time bounds behind a feature flag #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th7nder
requested review from
jmg-duarte and
cernicc
and removed request for
jmg-duarte
th7nder
force-pushed
the
fix/139/configure-time-units-for-testnet
branch
from
951d473 to
e3438fb
Compare
th7nder
added
ready for review
th7nder
force-pushed
the
fix/139/configure-time-units-for-testnet
branch
from
e3438fb to
e3dce27
Compare
th7nder
added
ready for review
th7nder
force-pushed
the
fix/139/configure-time-units-for-testnet
branch
from
e3dce27 to
0a2c6cd
Compare
th7nder
added
ready for review
cernicc
previously approved these changes
Jul 18, 2024
jmg-duarte
requested changes
Jul 18, 2024
th7nder
force-pushed
the
fix/139/configure-time-units-for-testnet
branch
2 times, most recently
from
2ce3e1c to
ec90b3a
Compare
th7nder
added
ready for review
jmg-duarte
requested changes
Jul 18, 2024
th7nder
force-pushed
the
fix/139/configure-time-units-for-testnet
branch
from
ec90b3a to
0efab99
Compare
th7nder
added
ready for review
jmg-duarte
requested changes
Jul 20, 2024
th7nder
force-pushed
the
fix/139/configure-time-units-for-testnet
branch
from
29a3e49 to
4cc5394
Compare
th7nder
added
ready for review
cernicc
added
ready for review
cernicc
approved these changes
Jul 22, 2024
th7nder
added
ready for review
jmg-duarte
approved these changes
Jul 22, 2024
jmg-duarte
force-pushed
the
fix/139/configure-time-units-for-testnet
branch
from
28ec866 to
b317101
Compare
jmg-duarte
added
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #139
This adds a feature flag
testnetfor the runtime and sets it as default.When runtime compiled with
testnetfeature flag, the order of waiting for deals to happen is reduced to minutes instead of days so we can effectively integration test them.This will be exposed to the clients.
I run it locally and submitted extrinsics, it works.
Checklist