Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pallet-market): settle_deal_payments return collateral #146

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Jul 18, 2024

Description

Fixes #142.
settle_deal_payments should unlock collateral when a deal is finished and not slashed.

Checklist

  • Make sure that you described what this change does.
  • Have you tested this solution?

@th7nder th7nder self-assigned this Jul 18, 2024
@th7nder th7nder requested review from jmg-duarte and cernicc July 18, 2024 12:38
@th7nder th7nder added bug Something isn't working ready for review Review is needed labels Jul 18, 2024
@th7nder th7nder added this to the Phase 1 milestone Jul 18, 2024
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 19, 2024
@th7nder th7nder requested a review from jmg-duarte July 21, 2024 18:26
…lateral after deal is finished without slashing
@jmg-duarte jmg-duarte force-pushed the fix/142/settle-deal-unlock-collateral branch from f7052c2 to a0c3950 Compare July 22, 2024 15:06
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jul 22, 2024
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 22, 2024
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 22, 2024
@cernicc cernicc merged commit e0de99d into develop Jul 23, 2024
3 checks passed
@cernicc cernicc deleted the fix/142/settle-deal-unlock-collateral branch July 23, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration Tests: settle deal does not unlock provider collateral
3 participants