-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storagext): implement declare faults_recovered #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc31217
to
e924353
Compare
e924353
to
ed00887
Compare
th7nder
approved these changes
Aug 15, 2024
ed00887
to
e89bd64
Compare
aidan46
previously approved these changes
Aug 15, 2024
th7nder
requested changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target/debug/storagext-cli --sr25519-key //Charlie storage-provider register charlie
target/debug/storagext-cli --sr25519-key //Alice market add-balance 25100200300
target/debug/storagext-cli --sr25519-key //Charlie market add-balance 25100200300
RUST_LOG=trace target/debug/storagext-cli --sr25519-key //Charlie market publish-storage-deals --client-sr25519-key //Alice @examples/deals.json
target/debug/storagext-cli --sr25519-key //Charlie storage-provider pre-commit @examples/pre-commit-sector.json
target/debug/storagext-cli --sr25519-key //Charlie storage-provider prove-commit @examples/prove-commit-sector.json
➜ polka-storage git:(feat/166/faults) ✗ target/debug/storagext-cli --sr25519-key //Charlie storage-provider declare-faults @examples/fault-declaration.json
thread 'main' panicked at cli/polka-storage/storagext-cli/src/cmd/storage_provider.rs:63:17:
Mismatch between definition and access of `faults`. Could not downcast to storagext::FaultDeclaration, need to downcast to alloc::vec::Vec<storagext::FaultDeclaration>
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fault-declaration.json contents:
[
{
"deadline": 0,
"partition": 0,
"sectors": [
0
]
}
]
th7nder
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
business logic may be flawed, but the CLI works:
a79e53de99fd5310d221326e0051c0f1986515cf3aa8e32dddcd80dd1"
2024-08-15T16:49:50.849045Z INFO run{address="5FLSigC9HGRKVhB9FiEo4Y3koPsNmBmLJbpXg2mp1hXcS59Y"}: storagext_cli::cmd::market: [0x916f…0dd1] Successfully published storage deals
2024-08-15T16:50:50.889228Z INFO run{address="5FLSigC9HGRKVhB9FiEo4Y3koPsNmBmLJbpXg2mp1hXcS59Y"}: storagext_cli::cmd::storage_provider: [0x6622…4934] Successfully pre-commited sector 1.
2024-08-15T16:51:50.918989Z INFO run{address="5FLSigC9HGRKVhB9FiEo4Y3koPsNmBmLJbpXg2mp1hXcS59Y"}: storagext_cli::cmd::storage_provider: [0x0947…ab01] Successfully proven sector 1.
Error: Runtime error: Pallet error: StorageProvider::DeadlineError
aidan46
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in the title.
Closes #166
Checklist