Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storagext-cli): quality of life improvements #210

Merged
merged 5 commits into from
Aug 16, 2024
Merged

feat(storagext-cli): quality of life improvements #210

merged 5 commits into from
Aug 16, 2024

Conversation

jmg-duarte
Copy link
Collaborator

Description

  • Bash scripts now stop on first error instead of limping along and show the command being executed
  • Implement env var reading for the keys in the storagext-cli

fixes #207

Checklist

  • Make sure that you described what this change does.
  • Have you tested this solution?

@jmg-duarte jmg-duarte added enhancement New feature or request pallet-storage-provider Relates to the Storage Provider Pallet labels Aug 16, 2024
@jmg-duarte jmg-duarte added this to the Phase 1 milestone Aug 16, 2024
@jmg-duarte jmg-duarte requested review from th7nder and aidan46 August 16, 2024 11:22
@jmg-duarte jmg-duarte self-assigned this Aug 16, 2024
th7nder
th7nder previously approved these changes Aug 16, 2024
View reviewed changes
@jmg-duarte jmg-duarte added the ready for review Review is needed label Aug 16, 2024
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Aug 16, 2024
@jmg-duarte jmg-duarte merged commit 418992a into develop Aug 16, 2024
3 checks passed
@jmg-duarte jmg-duarte deleted the feat/166/faults branch August 16, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th7nder th7nder th7nder approved these changes

@aidan46 aidan46 aidan46 approved these changes

Assignees

@jmg-duarte jmg-duarte

Labels
enhancement New feature or request pallet-storage-provider Relates to the Storage Provider Pallet ready for review Review is needed
Projects
None yet
Milestone
Phase 1
Development

Successfully merging this pull request may close these issues.

Investigate CLI/Parachain issue
3 participants
@jmg-duarte @th7nder @aidan46