Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add benchmarks #30

Closed
wants to merge 2 commits into from
Closed

ci: Add benchmarks #30

wants to merge 2 commits into from

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented May 21, 2024

Warning

This PR is on hold for now. We will revisit it when the runner instance is improved.

Add benchmarks for the polka-storage node to catch bugs.

Fixes #28

It is required to run a simple pass on benchmarks to catch bugs.

Fixes #28
@aidan46 aidan46 added the devops label May 21, 2024
@aidan46 aidan46 self-assigned this May 21, 2024
@aidan46 aidan46 marked this pull request as draft May 21, 2024 12:23
Copy link
Contributor

@serg-temchenko serg-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there anything new that should be added to this PR, or is it in its final state? If so, please move it to ready for review.

@aidan46
Copy link
Contributor Author

aidan46 commented May 24, 2024

Looks good. Is there anything new that should be added to this PR, or is it in its final state? If so, please move it to ready for review.

I am waiting for #37 to be merged so this PR does not eat up the GH minutes. I will merge the changes into this branch after that PR is merged.

@aidan46 aidan46 marked this pull request as ready for review May 24, 2024 12:59
@aidan46 aidan46 added the ready for review Review is needed label May 24, 2024
@serg-temchenko
Copy link
Contributor

On hold for now. Revisit when runner instance will be improved.

@aidan46
Copy link
Contributor Author

aidan46 commented May 31, 2024

On hold for now. Revisit when runner instance will be improved.

👍 I will convert this PR to a draft

@aidan46 aidan46 marked this pull request as draft May 31, 2024 07:59
@jmg-duarte jmg-duarte removed the ready for review Review is needed label Jun 18, 2024
@jmg-duarte jmg-duarte added the frozen PR/Issue is on hold label Jul 9, 2024
@jmg-duarte jmg-duarte closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops frozen PR/Issue is on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI benchmarks test
5 participants