Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add pr template #43

Merged
merged 3 commits into from
May 27, 2024
Merged

chore: add pr template #43

merged 3 commits into from
May 27, 2024

Conversation

cernicc
Copy link
Member

@cernicc cernicc commented May 24, 2024

Description

Added a new md file with the template. GitHub knows how to handle these kinda templates when creating a PR.

@cernicc cernicc added the ready for review Review is needed label May 24, 2024
@cernicc cernicc mentioned this pull request May 24, 2024
Closed
th7nder
th7nder requested changes May 24, 2024
View reviewed changes
.github/pull_request_template.md Outdated Show resolved Hide resolved
@cernicc cernicc linked an issue May 24, 2024 that may be closed by this pull request
Set up PR template #40
Closed
aidan46
aidan46 approved these changes May 24, 2024 •
edited
Loading
View reviewed changes
aidan46
aidan46 requested changes May 24, 2024
View reviewed changes
Copy link
Contributor

@aidan46 aidan46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make sections we can fill in like Description, Important points for reviewers, Related issues etc. so we can fill in the sections when putting up a PR.

@cernicc cernicc force-pushed the chore/40/pr_template branch from 76bd37a to 21471a6 Compare May 24, 2024 12:22
@cernicc
Copy link
Member Author

cernicc commented May 24, 2024

I'd make sections we can fill in like Description, Important points for reviewers, Related issues etc. so we can fill in the sections when putting up a PR.

Added the Important points for reviewers. I was not sure about Related issues. We can add after if it will be needed.

@cernicc cernicc requested review from th7nder and aidan46 May 24, 2024 12:26
@cernicc cernicc added ready for review Review is needed and removed ready for review Review is needed labels May 24, 2024
jmg-duarte
jmg-duarte requested changes May 24, 2024
View reviewed changes
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typo fixes & suggestions

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@cernicc cernicc requested review from aidan46 and jmg-duarte May 27, 2024 06:44
@cernicc cernicc added ready for review Review is needed and removed ready for review Review is needed labels May 27, 2024
@cernicc cernicc merged commit e2811c6 into develop May 27, 2024
3 checks passed
@cernicc cernicc deleted the chore/40/pr_template branch May 27, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidan46 aidan46 aidan46 approved these changes

@jmg-duarte jmg-duarte jmg-duarte approved these changes

@th7nder th7nder th7nder approved these changes

@serg-temchenko serg-temchenko Awaiting requested review from serg-temchenko

Assignees

@cernicc cernicc

Labels
ready for review Review is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up PR template
4 participants
@cernicc @th7nder @jmg-duarte @aidan46