Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polka storage provider cli component base implementation #55

Merged
merged 46 commits into from
Jun 19, 2024
Merged

polka storage provider cli component base implementation #55

merged 46 commits into from
Jun 19, 2024

Conversation

serg-temchenko
Copy link
Contributor

@serg-temchenko serg-temchenko commented May 29, 2024 •
edited
Loading

Description

This PR provides an entry point component to glue all lower-level components together. At this point it is a CLI app with wallet functionality, which reflects everything what provides subkey component.

Wallet functionality:

image

Important points for reviewers

Extension of this PR is in a PR #60.

Checklist

Please note that this is a partially resolves related task.

@serg-temchenko serg-temchenko self-assigned this May 29, 2024
@serg-temchenko serg-temchenko linked an issue May 29, 2024 that may be closed by this pull request
polka-storage component implementation #32
Closed
@serg-temchenko serg-temchenko mentioned this pull request May 29, 2024
Closed
@cernicc cernicc force-pushed the feat/32/polka-storage-component-implementation branch from b0270a6 to c1bc298 Compare June 4, 2024 06:19
@serg-temchenko serg-temchenko assigned cernicc and unassigned cernicc Jun 4, 2024
@serg-temchenko serg-temchenko added ready for review Review is needed and removed ready for review Review is needed labels Jun 14, 2024
th7nder
th7nder previously approved these changes Jun 14, 2024
View reviewed changes
jmg-duarte
jmg-duarte requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asides the CLI error being exposed in the primitives, LGTM

primitives/cli/src/lib.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/src/substrate.rs Outdated Show resolved Hide resolved
@serg-temchenko @jmg-duarte
fix(cs): Code style fix
6477753 
Co-authored-by: José Duarte <[email protected]>
@serg-temchenko serg-temchenko added ready for review Review is needed and removed ready for review Review is needed labels Jun 18, 2024
@serg-temchenko serg-temchenko added ready for review Review is needed and removed ready for review Review is needed labels Jun 18, 2024
@serg-temchenko serg-temchenko requested a review from th7nder June 18, 2024 14:19
jmg-duarte
jmg-duarte previously approved these changes Jun 18, 2024
View reviewed changes
th7nder
th7nder previously approved these changes Jun 18, 2024
View reviewed changes
@jmg-duarte jmg-duarte dismissed stale reviews from th7nder and themself via 319c872 June 19, 2024 09:22
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jun 19, 2024
@th7nder th7nder merged commit c8e657c into develop Jun 19, 2024
3 checks passed
@th7nder th7nder deleted the feat/32/polka-storage-component-implementation branch June 19, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmg-duarte jmg-duarte jmg-duarte approved these changes

@th7nder th7nder th7nder approved these changes

@cernicc cernicc Awaiting requested review from cernicc

@aidan46 aidan46 Awaiting requested review from aidan46

Assignees
No one assigned
Labels
ready for review Review is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

polka-storage component implementation
4 participants
@serg-temchenko @th7nder @jmg-duarte @cernicc